Fix for kintel's obj file cube corner testcase . #5016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using information provided by builder.vertexIndex
|
This implementation still doesn’t maintain more complex manifolds, but it’s an improvement from the current state, so let’s merge it! |
|
This came into my mind during lunch time too.
The Solution you are looking for it the plain dumb solution without
PolySetBuilder and this without PolySetBuilder..
I just introduced the polysetbuilder everywhere when doing the indexed
mode. Apparantly that was too nice 🤣
…On Mon, Feb 26, 2024 at 3:30 PM Marius Kintel ***@***.***> wrote:
Merged #5016 <#5016> into master.
—
Reply to this email directly, view it on GitHub
<#5016 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACCO4MUMFM5BLNVDE3AHOBLYVSMAXAVCNFSM6AAAAABDZ2PMH6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRHEZDEMZVHA2TCNY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Fixes #5015 |
|
I'm preparing some tests to exercise the manifold corner cases, so no action needed right now. I'll create new tickets as needed once I understand where we need to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using information provided by builder.vertexIndex