Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue3649 export filename not remembered #5031

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

otsakir
Copy link

@otsakir otsakir commented Mar 5, 2024

Reviewed the proposed export path algorithm to work better per-tab (#3649)

* Use previous export path for this suffix and tab if available.
* Fallback to "defaultExportDir" preference.
* If this is not available either use same path as .scad file.
* Fallback to system wide setting if .scad has not been saved yet.

Also adds "advanced/defaultExportDir" preference option.

This partly fixes #3649. It covers only the "path" part. Suggesting also the previous basename remains to be done (discussed further etc.).

… ref openscad#3649

* Use previous export path for this suffix and tab if available.
* Fallback to "defaultExportDir" preference.
* If this is not available either use same path as .scad file.
* Fallback to system wide setting if .scad has not been saved yet.
</widget>
</item>
<item>
<widget class="QLineEdit" name="lineEditDefaultExportDir"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This UI element also needs to offer a way for users to select a folder using a file dialog. Manually entering a folder name isn't very user friendly

@kintel
Copy link
Member

kintel commented Apr 7, 2024

Tested this on macOS. Looks good except for the preference UI mentioned in my review.
Someone should give this a spin on Windows too..

@otsakir
Copy link
Author

otsakir commented Apr 23, 2024

FYI, started working on

This UI element also needs to offer a way for users to select a folder using a file dialog. Manually entering a folder name isn't very user friendly

@otsakir
Copy link
Author

otsakir commented Apr 23, 2024

Added directory selection dialog triggered with a browse button. Currently it looks like this on Linux:

image

In terms of behavior, if the textbox already contains a directory it start from there. Otherwise, it uses PlatformUtils::userDocumentsPath() as a starting point.

@kintel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2021.01 - Export filename not remembered
2 participants