Fix svg import (stroke-linecap and stroke-linejoin) #5036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was "square", now is "butt" as stated as default value in SVG spec: https://www.w3.org/TR/SVG11/painting.html#StrokeLinecapProperty Fixes openscad#3809
With fix for openscad#3809 this test failed. New expected png now matches how other applications (firefox, gwenview, ...) render the input svg.
"miter" is the correct value name as per SVG spec: https://www.w3.org/TR/SVG11/painting.html#StrokeLinejoinProperty
t-paul
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wrong default for stroke-linecap, cause of #3809
Updates (wrong) expected png for related test (svgpngtest_spec-shapes-line01). I manually compared the old and the updated png to what Gwenview renders (which for the stuff mentioned in #3809 is the same as e.g. Firefox and other applications) and the updated png matches, the old one does not, because of the stroke-linecap.
Also fixes a wrong value name I noticed in an adjacent function for stroke-linejoin. There seems no test affected.
See commit messages for links to according part in SVG spec.