chore(python): migrate string format #5043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it make sense to go straight to f-strings? We probably are at >= Python 3.6 by now. I'm not sure if there's some sort of official view on string.format() vs. f-strings though. |
|
I did not used f-string because I found no requirement for the python scripts. I think it would also be ok to assume the currently supported Python versions (>=3.8) are available. |
|
Agreed, it seems the current minimum is 3.8. Added to the main readme via #5050.
|
From percent to f-string.
Rotzbua
force-pushed
the
chore_python2_string
branch
from
2de4515
to
887f2e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From percent to f-string.
Reference
Mentioned in #5040