Keep cursor position on save #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the file is saving, the cursor position was resetting to the top and you should keep scrolling by hand every time you save the file. This patch saves the scroll and cursor position and set it again after the file is refreshed so we can continue edition from where we were.
Before open a new file now we cleanup the Editor, so the new file get the cursor on the first character.
|
This is a good workaround. But my question is, why does the existing code call setPlainText() when you are saving a file? you getPlainText(), write that to a file, job done. |
|
The login in mainwindow.cc always relay on refreshDocument to load or reload the current opened file, and in the end is a QFile.readAll and then editor.setPlainText to set the code in the editor. I thing that there is no reason to reload the file when the file is saving, but I guess that is done this way because is harded to detect if the file must be reload because an "internal save" or need to be reload because an external program change it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using openscad a lot these days to start using my reprap 3D printer. Every time I hit "CTRL+S" for save my progress and see what changed, I was frustated by the fact that the cursos reset to the start of the file every time.
This patch aim to solve that problem. Before set the new file content via setPlainText I save the cursor position and the vertical scrollbar position and after the new text is set, I'm restoring that values to the original ones, so the cursor keeps in place and you can continue editing and the preview is updated at the same time.
When opening a new file, y set the content to an empty string, so the call on refreshDocument put the cursor at the start on the new file. Alto I'm doing boundary check to avoid putting the cursor past the last character.
I'm not used to user QT, so I hope the methos used to override the setPlainText is right, if not let me know.