Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous language changes #6

Closed
wants to merge 16 commits into from
Closed

Conversation

colah
Copy link

@colah colah commented Mar 25, 2011

  • Length of strings/vectors
  • Elements of strings accessible
  • Cross/Dot products (*,%)

@Harvie
Copy link

Harvie commented May 8, 2011

Syntax highlighting. Cool!
BTW i hope this will solve the issue that happen when i copy some scad example from web (eg.: wikibooks) and text formating gets into the OpenSCAD and can't be removed without removing whole formated text. why source code editor have formating enabled (even when pasting from clipboard)?
+1

@colah
Copy link
Author

colah commented May 11, 2011

@GilesBathgate: I see where you're coming from.

@Harvie, while it didn't, the version I just pushed should. Thanks for your interest in this project.

@brad
Copy link
Member

brad commented Oct 25, 2011

Is there a good reason not to accept at least the "Added length of vectors/string, accessing string characters" part? I would find that very useful and I have definitely heard a lot of others clamoring for these features.

@kintel
Copy link
Member

kintel commented Nov 12, 2011

The len() function has been submitted in a separate patch from Giles and is now merged.

@brad
Copy link
Member

brad commented Nov 12, 2011

That's great news! I don't mean to complain, but isn't it pretty useless to be able to get the length of a string if you can't do string indexing?

@kintel
Copy link
Member

kintel commented Nov 12, 2011

Yes, but it's a start - let's add one clean feature at the time.

@brad
Copy link
Member

brad commented Nov 13, 2011

Yes, good call.

@kintel
Copy link
Member

kintel commented Nov 13, 2011

String indexing was submitted as a separate patch by Brad and is now merged.

kintel added a commit that referenced this pull request Dec 21, 2011
@kintel
Copy link
Member

kintel commented Dec 21, 2011

Pulled the syntax highlighting stuff into a separate branch. I think we'll leave the rest for now.

@torwag torwag mentioned this pull request Oct 5, 2012
@kintel kintel mentioned this pull request Mar 27, 2013
kintel pushed a commit that referenced this pull request Mar 22, 2018
* writing the filename where the assertion failed

* use just the filename and update the tests

* relative path

* move the path handling to the exception handler
* update tests

* return fs::path to prevent accidental writes (#6)

* using PRINTB instead of stringstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants