Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make build fail when OpenCSG < 1.3.2 or CGAL < 3.9 #69

Closed
wants to merge 1 commit into from

Conversation

donbright
Copy link
Sponsor Member

mailing list has had several recent bug reports that were fixed by using updated library versions.

this patch will make the build itself fail. it would be better to detect the version within the build script, but that is rather difficult in qmake.

this will make the 'libcgal' packages on most linux versions unusable (outdated) with openscad, but it is relatively simple to build + install CGAL from source on linux.

the same is true of OpenCSG - 1.3.2 only came out in late late 2011. but it is also relatively easy to build and install on linux.

@kintel
Copy link
Member

kintel commented Jan 18, 2012

I find it a bit harsh to just fail. There might be reasons for using older versions.
.. but for release builds it would make sense I think.

@kintel
Copy link
Member

kintel commented Feb 4, 2012

Did you close this for a reason? The idea is good, I'm just unsure about when to enforce this behavior.

@donbright
Copy link
Sponsor Member Author

i was deleting all my old junk branches to clean things up, and i guess it closed this automatically?

yeah, i dont know when to do it either or how to do it.

i dont like having it in the source code either. i think it belongs inside the build system.

cmake it wouldn't be too bad, they have those VERSION functions you are already using. it could throw up a warning, and then allow people to pass a '-DFORCE_OLD_LIBRARY' option with old versions if they wanted to.

qmake, i have no idea how to do it in qmake. i guess there is probably a way some how. but i dont think it would be pretty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants