Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hub: remove a separate model used for a single permission #168

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

lzaoral
Copy link
Member

@lzaoral lzaoral commented Oct 31, 2023

The errata_xmlrpc_scan user permission was moved to the more appropriate Scan model.

@lzaoral lzaoral self-assigned this Oct 31, 2023
@lzaoral
Copy link
Member Author

lzaoral commented Nov 2, 2023

I've recreated the migration to resolve a conflict with another migration from #107.

@lzaoral lzaoral requested a review from kdudka November 2, 2023 15:39
Copy link
Contributor

@kdudka kdudka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Thanks!

The `errata_xmlrpc_scan` user permission was moved to the more
appropriate `Scan` model.
@lzaoral lzaoral merged commit 56e9eb9 into openscanhub:main Nov 8, 2023
17 checks passed
@lzaoral lzaoral deleted the hub-remove-permission-model branch November 8, 2023 08:25
@kdudka
Copy link
Contributor

kdudka commented Nov 14, 2023

@lzaoral I am not able to update user permissions through web UI for a user name that contains /:

Enter a valid username. This value may contain only letters, numbers and @/./+/-/_ characters.

In this case, the user is a Kerberos service principal. However, last week I hit a similar problem with a user named worker/..., which OSH/kobo automatically creates for each worker. Any idea if we could somehow relax this check at /osh/admin/kobo_auth/user/?

Apparently, such users exist in OSH and anything but Django Admin is able to work with them.

@lzaoral
Copy link
Member Author

lzaoral commented Nov 15, 2023

@lzaoral I am not able to update user permissions through web UI for a user name that contains /:

Enter a valid username. This value may contain only letters, numbers and @/./+/-/_ characters.

In this case, the user is a Kerberos service principal. However, last week I hit a similar problem with a user named worker/..., which OSH/kobo automatically creates for each worker. Any idea if we could somehow relax this check at /osh/admin/kobo_auth/user/?

Apparently, such users exist in OSH and anything but Django Admin is able to work with them.

This is an issue unrelated to this PR. Moved to #185.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants