Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hub: make footer of the e-mail notifications #251

Merged
merged 2 commits into from Apr 29, 2024

Conversation

siteshwar
Copy link
Member

... configurable through settings.

Resolves: https://issues.redhat.com/browse/OSH-252

@siteshwar
Copy link
Member Author

siteshwar commented Apr 4, 2024

I have modified this pull request to also include footer for the tasks (non-errata scans).

Example Task (non-errata scan) notification:

---------- MESSAGE FOLLOWS ----------
b'Content-Type: text/plain; charset="utf-8"'
b'MIME-Version: 1.0'
b'Content-Transfer-Encoding: 7bit'
b'Subject: Task [#7] units-2.22-6.fc39 finished, state: CLOSED'
b'From: no-reply@example.org'
b'To: user@example.com'
b'Date: Thu, 04 Apr 2024 16:16:27 -0000'
b'Message-ID: <171224738772.3382.8612301540682693862@osh-hub>'
b'X-Task-ID: 7'
b'X-Task-State: CLOSED'
b'X-Task-Owner: user'
b'X-Scan-Build: units-2.22-6.fc39'
b'X-Application-ID: OpenScanHub'
b'X-Hostname: osh-hub'
b'X-Peer: ::1'
b''
b'Hostname: osh-hub'
b'Task ID: 7'
b'Build: units-2.22-6.fc39'
b'Task state: CLOSED'
b'Task owner: user'
b'Task method: MockBuild'
b''
b'Task URL: http://osh-hub:8000/task/7/'
b'Comment: '
b''
b''
b'All defects'
b''
b'CLANG_WARNING             13'
b'COMPILER_WARNING          4'
b'CPPCHECK_WARNING          5'
b'GCC_ANALYZER_WARNING      6'
b''
b'This is a test footer.'
------------ END MESSAGE ------------

@siteshwar siteshwar marked this pull request as ready for review April 4, 2024 14:11
@siteshwar siteshwar changed the title hub: make footer of the e-mail notifications hub: make footer of the e-mail notifications configurable Apr 4, 2024
@siteshwar siteshwar changed the title hub: make footer of the e-mail notifications configurable hub: make footer of the e-mail notifications Apr 4, 2024
ryanlerch pushed a commit to fedora-infra/ansible that referenced this pull request Apr 15, 2024
Related: openscanhub/openscanhub#251

Signed-off-by: Siteshwar Vashisht <svashisht@redhat.com>
Copy link
Contributor

@kdudka kdudka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

osh/hub/scan/notify.py Outdated Show resolved Hide resolved
osh/hub/scan/notify.py Outdated Show resolved Hide resolved
... configurable through settings.

Resolves: https://issues.redhat.com/browse/OSH-252

Signed-off-by: Siteshwar Vashisht <svashisht@redhat.com>
... generated by `osh-cli` tasks (non-errata scans).

Signed-off-by: Siteshwar Vashisht <svashisht@redhat.com>
@siteshwar siteshwar merged commit bb10114 into openscanhub:main Apr 29, 2024
7 of 8 checks passed
@lzaoral
Copy link
Member

lzaoral commented Apr 29, 2024

@siteshwar Please, always wait for the Lint job to finish before you merge!! https://github.com/openscanhub/openscanhub/actions/runs/8876473051/job/24368050609

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants