feat(openscd): Move progress indicator beneath plugin tabs

[danyill]

Closes #1178.

Unfortunately, the buttons and the title already overlap in the mobile view, which means the progress indicator on a small mobile screen will hover in the centre of the screen.

This is not ideal, but I can't think of a better location, and would be willing to live with myself over this...

Otherwise I quite like it:

This especially bothered me on the subscriber plugins where I was constantly carrying out an action, near the centre of the screen and found the progress indicator distracting and overpowering.

As always a review would be appreciated as CSS has been carefully designed to impart humility and there is no reason why I should be exempt.

I wonder if this is inadequate -- I'm not sure how CoMPAS downstream integrates or consumes open-scd, I know it's top bar is different. Perhaps this needs to be slotted somewhere?

[danyill]

After our discussion at a recent refinement I'll look into other options to improve compatibility with CoMPAS.

[danyill]

I first tried to put the progress bar under the filename. Can be done but impossible to style with mwc linear progress out of the box (it seems to me) as I can't apply suitable overrides.

So I thought why don't I put it just below the tab bar and have it occupy the full width? Not perfect but better. I've decreased the opacity to make it less visually intrusive.

I wanted to avoid the progress bar being on top of the menu if a validation action is triggered from a menu action.
So I made a menu plugin action always close the menu. This is, I hope a general improvement and works nicely except that the menu plugin, "Show SCL History" goes into an infinite update loop and never opens. I may need some help with why this occurs (how odd?!)

[ca-d]

I'd really prefer rendering the linear progress bar between the editor plugin and the menu (in terms of CSS layering, meaning arranging it in the DOM to appear after the editor plugin but still inside the drawer) and removing the z-index definition. Do you think that is a viable alternative?

Addressed in later commits.

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
18.8% Duplication

[danyill]

@ca-d, is there anything I can do to move this along?

[pascalwilbrink]

Looks good! quick scan is saying that mwc-circular-progress-four-color isn't being used anymore. Can it be removed from the package.json?

[danyill]

Thank you for this review, I have merged to main and cleaned up the package.

[danyill]

@pascalwilbrink are you happy with the changes to the package?

[danyill]

Thanks for the review!