Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editing): use editCount property for change propagation #1233

Merged
merged 7 commits into from
Jun 21, 2023

Conversation

ca-d
Copy link
Contributor

@ca-d ca-d commented Apr 17, 2023

This fixes several issues related to replacing our document by already moving to the open-scd-core way of propagating change to plugins: an editCount representing where we are in the edit history, which is passed in addition to the docName and doc.

@ca-d ca-d added the Kind: Bug Something isn't working label Apr 17, 2023
@ca-d ca-d added this to the Sprint 2023-19-04 milestone Apr 17, 2023
@ca-d ca-d requested a review from danyill April 17, 2023 18:55
danyill
danyill previously approved these changes Apr 23, 2023
Copy link
Collaborator

@danyill danyill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for attending to this important matter, I am most grateful 👍 💌

I have rebased #1222 on this PR and found that it resolves the errors and issues encountered there. I now am able to import all IEDs without any failures (silent or console errors) on both Chrome and Firefox.

I have done limited testing of plugins and not found any regressions.

src/editors/substation/foundation.ts Outdated Show resolved Hide resolved
src/Plugging.ts Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
74.0% 74.0% Duplication

@Sander3003
Copy link
Member

@ca-d what is the status of this pull-request?

@ca-d
Copy link
Contributor Author

ca-d commented May 17, 2023

@Sander3003 there's an intermittent timing error in the tests (see currently failing test on test&build while regular test runs) that nobody has fixed yet. This currently needs help.

@ca-d
Copy link
Contributor Author

ca-d commented May 17, 2023

Also SonarCloud seems to be complaining about something, might be worth checking out.

@ca-d ca-d added the Status: Help wanted Extra attention is needed label May 30, 2023
Stef3st and others added 2 commits May 31, 2023 11:17
Signed-off-by: Stef3st <steffen.van.den.driest@alliander.com>
Signed-off-by: Stef3st <steffen.van.den.driest@alliander.com>
Signed-off-by: Stef3st <steffen.van.den.driest@alliander.com>
@Stef3st Stef3st requested a review from danyill June 6, 2023 12:34
Copy link
Collaborator

@danyill danyill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for looking at the tests @Stef3st

@danyill
Copy link
Collaborator

danyill commented Jun 13, 2023

I'd quite like to see this merged soon - is this something you'd like to do @ca-d, I'm happy to merge unless you'd like to review the latest changes.

@ca-d
Copy link
Contributor Author

ca-d commented Jun 16, 2023

I'd quite like to see this merged soon - is this something you'd like to do @ca-d, I'm happy to merge unless you'd like to review the latest changes.

Please merge at your pleasure as long as @Stef3st considers this ready!

@danyill danyill merged commit 548f63b into main Jun 21, 2023
2 checks passed
@danyill danyill deleted the add-edit-count branch June 21, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kind: Bug Something isn't working Status: Help wanted Extra attention is needed
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants