Feat: Added XML Package for OpenSCD #1536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juancho0202
suggested changes
Jun 3, 2024
There was a problem hiding this comment.
Everything looks well executed in the extraction, my only concern is that the migrated tests from packages/open-scd to packages/xml are not being executed because there is no test script and no devDependency on "@web/test-runner" at the @openscd/xml project.
If you add that missing bit this is complete imo.
pascalwilbrink
force-pushed
the
OpenSCD_XML
branch
from
b1f3b28
to
2263389
Compare
pascalwilbrink
force-pushed
the
OpenSCD_XML
branch
from
2d97abd
to
29cd493
Compare
juancho0202
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.