Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add credential generation info to the /osdf/namespaces endpoint #3055

Merged
merged 7 commits into from
Mar 29, 2023
Merged

Add credential generation info to the /osdf/namespaces endpoint #3055

merged 7 commits into from
Mar 29, 2023

Conversation

matyasselmeci
Copy link
Collaborator

bbockelm
bbockelm reviewed Mar 29, 2023
View reviewed changes
src/tests/test_api.py Outdated Show resolved Hide resolved
bbockelm
bbockelm approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@bbockelm bbockelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few ideas around URL validation improvements but it doesn't need to hold up the train.

@matyasselmeci matyasselmeci merged commit 4ce992c into opensciencegrid:master Mar 29, 2023
@matyasselmeci matyasselmeci deleted the pr/namespaces-credential-generation.SOFTWARE-5381 branch March 29, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbockelm bbockelm bbockelm approved these changes

@brianhlin brianhlin Awaiting requested review from brianhlin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matyasselmeci @bbockelm