Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS paper #7

Merged
merged 12 commits into from Oct 7, 2020
Merged

JOSS paper #7

merged 12 commits into from Oct 7, 2020

Conversation

znicholls
Copy link
Contributor

@znicholls znicholls commented May 15, 2020

Add JOSS paper

@znicholls znicholls requested a review from rgieseke May 15, 2020 10:43
@znicholls znicholls marked this pull request as ready for review October 4, 2020 02:40
@znicholls
Copy link
Contributor Author

@rgieseke can you take a look please? I think JOSS are now accepting papers again

@rgieseke
Copy link
Member

rgieseke commented Oct 6, 2020

Looks good to me!
I think i haven't contributed significantly during the model implementation, so i removed myself from the authors list.

Some comments/suggestions on the paper text below:

  • maybe add a sentence describing the model assumptions of the two layers? It is described how it is extended but not really the initial fast/slow components
  • add reference to RCMIP Phase 1 paper, where this implementation is used, this feeds also in the required "Statement of Need", as it was sort of a benchmark model for RCMIP
  • has FaIR already implemented this (as alluded in last paragraph) https://github.com/OMS-NetZero/FAIR/blob/master/fair/temperature/geoffroy.py
    The point of FaIR not being modularised yet is probably a bit out of scope for the JOSS paper. The two sentences on FaIR could probably be condensed into one.
  • last sentence, maybe just "used in research or education", "interested parties" is probably would use it for research or (self-)education
  • make RCP, CMIP5, AOGCM uppercase in BibTex bibliography
  • make tag "simple climate model" instead of "simple models"
  • add tag "reduced complexity climate model"
  • add tag "energy balance"

@znicholls
Copy link
Contributor Author

Awesome thanks! Time to submit :)

@znicholls znicholls merged commit d247c3d into master Oct 7, 2020
@znicholls znicholls deleted the joss-paper branch October 7, 2020 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants