Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autorelease #27

Merged
merged 3 commits into from Jul 23, 2021
Merged

Autorelease #27

merged 3 commits into from Jul 23, 2021

Conversation

mikapfl
Copy link
Member

@mikapfl mikapfl commented Jul 22, 2021

Pull request

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Example added (either to an existing notebook or as a new notebook, where applicable)
  • Description in CHANGELOG.rst added

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <https://github.com/openscm/openscm-units/pull/XX>`_) Added feature which does something
- (`#XX <https://github.com/openscm/openscm-units/pull/XX>`_) Fixed bug identified in (`#YY <https://github.com/openscm/openscm-units/issues/YY>`_)

@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #27 (46a23f9) into master (8113bfe) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #27   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          116       116           
  Branches        17        17           
=========================================
  Hits           116       116           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8113bfe...46a23f9. Read the comment docs.

Copy link
Contributor

@znicholls znicholls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wicked, was probably some mucking around but can definitely be re-used!

@mikapfl
Copy link
Member Author

mikapfl commented Jul 23, 2021

If you want it merged, you have to do it yourself, I can't merge even though you have approved it. 🙂

@znicholls
Copy link
Contributor

I just gave you write access, can you merge now?

@mikapfl mikapfl merged commit 91e8911 into openscm:master Jul 23, 2021
@mikapfl mikapfl deleted the autorelease branch July 23, 2021 10:16
@znicholls
Copy link
Contributor

Nice when it all works :) https://github.com/openscm/openscm-units/runs/3236053015?check_suite_focus=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants