Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated outdated docs about NOx conversions. #34

Merged
merged 2 commits into from Feb 8, 2022

Conversation

mikapfl
Copy link
Member

@mikapfl mikapfl commented Feb 3, 2022

Pull request

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Example added (either to an existing notebook or as a new notebook, where applicable)
  • Description in CHANGELOG.rst added

NOx is not a simple alias for NO2 any more. Update docs accordingly.

Prompted by pik-primap/primap2#96

@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #34 (a925578) into master (ad21956) will not change coverage.
The diff coverage is n/a.

❗ Current head a925578 differs from pull request most recent head 646f5c0. Consider uploading reports for the commit 646f5c0 to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #34   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          122       122           
  Branches        19        19           
=========================================
  Hits           122       122           
Impacted Files Coverage Δ
src/openscm_units/_unit_registry.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad21956...646f5c0. Read the comment docs.

@mikapfl
Copy link
Member Author

mikapfl commented Feb 3, 2022

The linting failure is fixed in 0903fa5 . I think including it here as well would cause merge conflicts later on?

@mikapfl
Copy link
Member Author

mikapfl commented Feb 3, 2022

Ah, no, sorry, other problem. Apparently, a newer black version. May I interest you in https://pre-commit.ci/ for auto-fixing black commits?

@mikapfl
Copy link
Member Author

mikapfl commented Feb 3, 2022

The liniting failure which is now left is actually 0903fa5 .

@znicholls
Copy link
Contributor

May I interest you in https://pre-commit.ci/ for auto-fixing black commits?

Ye sure

I think including it here as well would cause merge conflicts later on?

Ye up to you if you want to just wait for #33 or rebase #33 later

Copy link
Contributor

@znicholls znicholls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome thanks!

@mikapfl mikapfl merged commit f97fac6 into openscm:master Feb 8, 2022
@mikapfl mikapfl deleted the nox-doc-fix branch February 8, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants