Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAGICC7 compatibility #20

Closed
rgieseke opened this issue May 31, 2018 · 8 comments
Closed

MAGICC7 compatibility #20

rgieseke opened this issue May 31, 2018 · 8 comments
Labels
Milestone

Comments

@rgieseke
Copy link
Member

General question, @lewisjared @znicholls -- might be helpful for decisions on how to make design decisions.

Do we need to maintain MAGICC6 compatibility once MAGICC7 is publicly available?

Will there be a need to run both from one installation? Do you need this to run regressions tests/comparisons for MAGICC7?

One could always install version 1.x and run MAGICC6, might mean separate Virtualenvs if you actually do need both but I'd think that would be fairly rare.

@znicholls
Copy link
Collaborator

Great question, backwards compatibility is not something we've done well with MAGICC before I don't think. Maintaining it will require some head scratching but it might be worth it.

I guess ultimately it depends how much you want to be able to compare the two versions and how easily. Given MAGICC6 was so heavily used in AR5 I doubt people will lose interest in it anytime soon. I would obviously enjoy the ability to compare them easily (i.e. without switching environments) but I don't think this is compulsory. I also think if we don't maintain MAGICC6 compatibility then we may lose the ability to run it which could be annoying in some cases.

Thoughts @lewisjared @rgieseke ?

@lewisjared
Copy link
Collaborator

lewisjared commented May 31, 2018 via email

@znicholls
Copy link
Collaborator

znicholls commented May 31, 2018 via email

@znicholls
Copy link
Collaborator

znicholls commented May 31, 2018 via email

@rgieseke
Copy link
Member Author

Obviously it's your project robert so I'm happy to follow your lead and
don't want to tread on toes

No, it's for everyone who wants use it (and everyone is free to fork and modify) -- I just try to keep maintainable what I'm currently maintaining :-)

It seems clear that we all want and could make use of having both MAGICC6 and MAGICC7 included!

@znicholls
Copy link
Collaborator

Ok great let's go for it then

@rgieseke rgieseke added this to the MAGICC7 milestone May 31, 2018
@znicholls
Copy link
Collaborator

@rgieseke can we close this? Or not until we are shipping with a MAGICC7 executable?

@rgieseke
Copy link
Member Author

rgieseke commented Jul 9, 2018

I think we're sufficiently discussed and now have MAGICC7 compatibility in ...

@rgieseke rgieseke closed this as completed Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants