New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to openscm conventions #154
Conversation
Column headers convention: Variable and acronym naming convention: 'B' becomes" MAGICC AFOLU" Regional split: |
'World' rather than 'Global' here is jarring but it's better to be consistent with Pyam than precious |
from earlier discussions:
|
@rgieseke |
f3c4a70
to
d3be60a
Compare
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
=========================================
+ Coverage 96.33% 96.73% +0.4%
=========================================
Files 4 5 +1
Lines 981 1132 +151
Branches 134 174 +40
=========================================
+ Hits 945 1095 +150
+ Misses 22 20 -2
- Partials 14 17 +3
Continue to review full report at Codecov.
|
5564107
to
a306b43
Compare
Questions to answer: - column header convention (I'd follow pyam so lowercase everything) - variable naming convention (I'd be tempted to copy pyam so captialise words e.g. Emissions|CO2|Land-use & Agriculture) - suffixes to use re 'I' and 'B' - regional split to use re land/ocean, NH/SH - acronyms to use e.g. "BC" or "Black Carbon"
Almost there, need to fix replacements generators and units writing
Tomorrow - speed up - tidy up - merge
fb495e0
to
ab4ff71
Compare
@rgieseke this one is pretty massive. Tried to keep it just to the minimum I needed, unfortunately that's quite a lot... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Pull request
Please confirm that this pull request has done the following:
CHANGELOG.rst
addeddict
(moved to Move to one backend, not two #161)Adding to CHANGELOG.rst
Please add a single line in the changelog notes similar to one of the following: