New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove emergency region renaming #184
Conversation
@rgieseke @lewisjared good to follow #183 |
0c62236
to
7f06018
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just a tiny question ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice tidyup. Can confirm that this works with a fresh checkout of master for magicc (only needed some changes to MAGCFG_USER.CFG)
@lewisjared can you hit the button (trying to avoid merge request authors doing the merging) |
Is the default practise to squash or rebase? |
rebase
…On Mon, Dec 17, 2018 at 12:42 PM Jared Lewis ***@***.***> wrote:
Is the default practise to squash or rebase?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#184 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AWh-m4h6UMmMYpuJLmx-bCMEzvueNWriks5u5vaagaJpZM4ZOqO4>
.
|
Pull request
Please confirm that this pull request has done the following:
CHANGELOG.rst
addedAdding to CHANGELOG.rst
Please add a single line in the changelog notes similar to one of the following:
@rgieseke @lewisjared going to have to test this one locally, make sure you've got latest version of the MAGICC master branch. Your CFG needs to look like this too