Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more robust test of io #229

Merged
merged 13 commits into from Apr 16, 2019
Merged

Add more robust test of io #229

merged 13 commits into from Apr 16, 2019

Conversation

znicholls
Copy link
Collaborator

@znicholls znicholls commented Apr 8, 2019

Pull request

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Example added (either to an existing notebook or as a new notebook, where applicable) (N/A, all internal)
  • Description in CHANGELOG.rst added

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <http://link-to-pr.com>`_) Added feature which does something
- (`#XX <http://link-to-pr.com>`_) Fixed bug identified in (`#XX <http://link-to-issue.com>`_)

@znicholls
Copy link
Collaborator Author

@lewisjared can you take a look when you've got a minute? Let's not merge until @rgieseke gives the approval though

@znicholls znicholls marked this pull request as ready for review April 8, 2019 01:21
Copy link
Collaborator

@lewisjared lewisjared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are any of these expected files actually run through magicc to be sure that they work?

pymagicc/io.py Outdated Show resolved Hide resolved
pymagicc/io.py Outdated Show resolved Hide resolved
@znicholls
Copy link
Collaborator Author

znicholls commented Apr 8, 2019

Are any of these expected files actually run through magicc to be sure that they work?

They are now in tests/test_core.py::test_pymagicc_writing_has_an_effect (except the OT file because I have no idea how that's used and hence how to test it...)

@znicholls
Copy link
Collaborator Author

@rgieseke if you have time would be great to get your thoughts

pymagicc/io.py Outdated Show resolved Hide resolved
@rgieseke
Copy link
Member

Excellent documentation of pit-falls, very useful to have this written down here!
Only question from my side the debug statement ...

@znicholls
Copy link
Collaborator Author

@lewisjared over to you to merge when you're happy then I think

@lewisjared lewisjared merged commit e448699 into master Apr 16, 2019
@rgieseke rgieseke deleted the io-updates branch June 13, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants