Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use openscm release #244

Merged
merged 10 commits into from May 9, 2019
Merged

Use openscm release #244

merged 10 commits into from May 9, 2019

Conversation

znicholls
Copy link
Collaborator

@znicholls znicholls commented May 7, 2019

Pull request

Update pymagicc to use the pre-release of openscm (mainly for testing purposes but the API should be pretty stable...). Also tidies up setup.py and Makefile as well as dropping join_timeseries (all of its functionality is superceded by OpenSCM).

Please confirm that this pull request has done the following:

  • Tests added (N/A)
  • Documentation added (where applicable) (N/A)
  • Example added (either to an existing notebook or as a new notebook, where applicable) (N/A)
  • Description in CHANGELOG.rst added

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <http://link-to-pr.com>`_) Added feature which does something
- (`#XX <http://link-to-pr.com>`_) Fixed bug identified in (`#XX <http://link-to-issue.com>`_)

@znicholls znicholls requested a review from rgieseke May 8, 2019 00:00
@znicholls znicholls changed the title WIP: Use openscm release Use openscm release May 8, 2019
.travis.yml Outdated Show resolved Hide resolved
@znicholls znicholls requested a review from rgieseke May 8, 2019 06:29
Copy link
Member

@rgieseke rgieseke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rgieseke rgieseke merged commit e1103b4 into master May 9, 2019
@rgieseke rgieseke deleted the use-openscm-release branch June 13, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants