Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow out_dynamic_vars parameter to be used #253

Merged
merged 3 commits into from Jul 2, 2019
Merged

Allow out_dynamic_vars parameter to be used #253

merged 3 commits into from Jul 2, 2019

Conversation

lewisjared
Copy link
Collaborator

@lewisjared lewisjared commented Jul 2, 2019 •
edited

Pull request

Please confirm that this pull request has done the following:

  • Tests added
  • Description in CHANGELOG.rst added

Doesn't convert out_dynamic_vars to an integer

@lewisjared
Copy link
Collaborator Author

#254

@lewisjared lewisjared requested a review from znicholls July 2, 2019 05:07
@lewisjared
Copy link
Collaborator Author

It would be nice to have a beta.2 release after this as this is super handy for the api

znicholls
znicholls approved these changes Jul 2, 2019
View reviewed changes
pymagicc/core.py Show resolved Hide resolved
@znicholls
Copy link
Collaborator

It would be nice to have a beta.2 release after this as this is super handy for the api

Can do

@znicholls znicholls merged commit f0bf593 into master Jul 2, 2019
@znicholls znicholls deleted the dynamic-vars branch July 2, 2019 07:35
@znicholls
Copy link
Collaborator

@lewisjared https://pypi.org/project/pymagicc/2.0.0b3/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@znicholls znicholls znicholls approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lewisjared @znicholls