Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update variable mapping #261

Merged
merged 7 commits into from Aug 20, 2019
Merged

Update variable mapping #261

merged 7 commits into from Aug 20, 2019

Conversation

znicholls
Copy link
Collaborator

@znicholls znicholls commented Aug 18, 2019

Pull request

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable) (N/A)
  • Example added (either to an existing notebook or as a new notebook, where applicable) (N/A)
  • Description in CHANGELOG.rst added

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <http://link-to-pr.com>`_) Added feature which does something
- (`#XX <http://link-to-pr.com>`_) Fixed bug identified in (`#XX <http://link-to-issue.com>`_)

Copy link
Collaborator

@lewisjared lewisjared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it handle DAT_SURFACE_TEMP_SUBANNUAL or *_GWPEMIS?

tests/test_definitions.py Show resolved Hide resolved
pymagicc/definitions/__init__.py Outdated Show resolved Hide resolved
@znicholls
Copy link
Collaborator Author

Does it handle DAT_SURFACE_TEMP_SUBANNUAL or *_GWPEMIS?

DAT_SURFACE_TEMP_SUBANNUAL nope but will add. I'd rather not support *_GWPEMIS, I think this sort of conversion should be done in post-processing rather than relying on the values hard-coded in MAGICC to be right...

znicholls and others added 2 commits August 19, 2019 10:19
Co-Authored-By: Jared Lewis <jared@jared.kiwi.nz>
@lewisjared lewisjared merged commit 32425b2 into master Aug 20, 2019
@znicholls znicholls deleted the variable-mapping branch October 30, 2019 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants