Switch to using a whitelist for out_ flags #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm. I'd probably prefer to have just added exceptions to the rule rather than the whitelist but that's splitting hairs. If you rebase on #267 this should pass (I think). |
znicholls
approved these changes
Oct 21, 2019
lewisjared
force-pushed
the
hotfix-out-params
branch
from
9fb8273
to
f298255
Compare
|
I started on that but realised the list of exceptions are just as long. These shouldn't change in future as |
|
cool rebase then we're good |
lewisjared
force-pushed
the
hotfix-out-params
branch
from
f298255
to
d2e1fe5
Compare
lewisjared
force-pushed
the
hotfix-out-params
branch
from
d2e1fe5
to
9cc6d33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Please confirm that this pull request has done the following:
CHANGELOG.rstadded