Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using scmdata #269

Merged
merged 5 commits into from Oct 29, 2019
Merged

Switch to using scmdata #269

merged 5 commits into from Oct 29, 2019

Conversation

znicholls
Copy link
Collaborator

@znicholls znicholls commented Oct 29, 2019

Pull request

Please confirm that this pull request has done the following:

  • Tests added (N/A)
  • Documentation added (where applicable) (N/A)
  • Example added (either to an existing notebook or as a new notebook, where applicable) (N/A)
  • Description in CHANGELOG.rst added

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <http://link-to-pr.com>`_) Added feature which does something
- (`#XX <http://link-to-pr.com>`_) Fixed bug identified in (`#XX <http://link-to-issue.com>`_)

Copy link
Collaborator

@lewisjared lewisjared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Version bump??

@znicholls znicholls mentioned this pull request Oct 29, 2019
4 tasks
@znicholls
Copy link
Collaborator Author

Version bump??

Will do once tests pass...

@rgieseke
Copy link
Member

Super nice! Not having these circular dependencies should make things easier :-)

@znicholls
Copy link
Collaborator Author

znicholls commented Oct 29, 2019

Super nice! Not having these circular dependencies should make things easier :-)

Yep fingers crossed we're on our way down the complexity hill!

@znicholls znicholls merged commit 251ca0a into master Oct 29, 2019
@znicholls znicholls deleted the switch-to-scmdata branch October 29, 2019 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants