Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compact out readers #277

Merged
merged 10 commits into from Apr 28, 2020
Merged

Compact out readers #277

merged 10 commits into from Apr 28, 2020

Conversation

znicholls
Copy link
Collaborator

@znicholls znicholls commented Dec 22, 2019

Pull request

Please confirm that this pull request has done the following:

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <http://link-to-pr.com>`_) Added feature which does something
- (`#XX <http://link-to-pr.com>`_) Fixed bug identified in (`#XX <http://link-to-issue.com>`_)

@znicholls
Copy link
Collaborator Author

znicholls commented Dec 22, 2019

@rgieseke and @lewisjared this is good to go I think (following #276). I've made a separate issue for docs (#279) so we don't forget but I don't think there's much point doing docs now as MAGICC7 isn't available.

@znicholls znicholls marked this pull request as ready for review December 22, 2019 06:43
Copy link
Collaborator

@lewisjared lewisjared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor refactors

pymagicc/io.py Outdated Show resolved Hide resolved
pymagicc/io.py Show resolved Hide resolved
pymagicc/io.py Show resolved Hide resolved
pymagicc/io.py Show resolved Hide resolved
pymagicc/io.py Outdated Show resolved Hide resolved
@znicholls znicholls marked this pull request as draft April 28, 2020 01:53
@znicholls znicholls marked this pull request as ready for review April 28, 2020 02:53
@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #277 into master will increase coverage by 0.03%.
The diff coverage is 95.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
+ Coverage   94.61%   94.64%   +0.03%     
==========================================
  Files           7        7              
  Lines        2245     2351     +106     
  Branches      449      469      +20     
==========================================
+ Hits         2124     2225     +101     
- Misses         83       87       +4     
- Partials       38       39       +1     
Impacted Files Coverage Δ
pymagicc/io.py 95.53% <95.28%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d34c8c2...4a143f6. Read the comment docs.

@znicholls znicholls merged commit 3ba5446 into master Apr 28, 2020
@znicholls znicholls deleted the compact-out-readers branch April 28, 2020 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants