New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compact out readers #277
Compact out readers #277
Conversation
@rgieseke and @lewisjared this is good to go I think (following #276). I've made a separate issue for docs (#279) so we don't forget but I don't think there's much point doing docs now as MAGICC7 isn't available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some minor refactors
e71698f
to
ec508e4
Compare
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
==========================================
+ Coverage 94.61% 94.64% +0.03%
==========================================
Files 7 7
Lines 2245 2351 +106
Branches 449 469 +20
==========================================
+ Hits 2124 2225 +101
- Misses 83 87 +4
- Partials 38 39 +1
Continue to review full report at Codecov.
|
Pull request
Please confirm that this pull request has done the following:
CHANGELOG.rst
addedAdding to CHANGELOG.rst
Please add a single line in the changelog notes similar to one of the following: