Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose get tcr ecs from diagnosis results #282

Merged
merged 5 commits into from Mar 5, 2020

Conversation

znicholls
Copy link
Collaborator

Pull request

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Example added (either to an existing notebook or as a new notebook, where applicable) (N/A)
  • Description in CHANGELOG.rst added

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <http://link-to-pr.com>`_) Added feature which does something
- (`#XX <http://link-to-pr.com>`_) Fixed bug identified in (`#XX <http://link-to-issue.com>`_)

@znicholls znicholls mentioned this pull request Mar 4, 2020
4 tasks
Copy link
Collaborator

@lewisjared lewisjared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I don't think that this functionality should be in core, but that's a debate for another day

@znicholls
Copy link
Collaborator Author

LGTM although I don't think that this functionality should be in core, but that's a debate for another day

I agree, it's pretty messy at the moment. Let's discuss in #286. If you're happy, can you merge please?

@lewisjared lewisjared merged commit 87df474 into master Mar 5, 2020
@znicholls znicholls deleted the expose-get_tcr_ecs_from_diagnosis_results branch March 5, 2020 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants