Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update name in docs #300

Merged
merged 2 commits into from Jun 26, 2020
Merged

Update name in docs #300

merged 2 commits into from Jun 26, 2020

Conversation

znicholls
Copy link
Collaborator

@znicholls znicholls commented Jun 26, 2020

Pull request

Closes #205

Please confirm that this pull request has done the following:

  • Tests added (N/A)
  • Documentation added (where applicable)
  • Example added (either to an existing notebook or as a new notebook, where applicable) (N/A)
  • Description in CHANGELOG.rst added

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <http://link-to-pr.com>`_) Added feature which does something
- (`#XX <http://link-to-pr.com>`_) Fixed bug identified in (`#XX <http://link-to-issue.com>`_)

@znicholls znicholls requested a review from rgieseke June 26, 2020 13:16
Copy link
Member

@rgieseke rgieseke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i mean looked bad to me ...

@rgieseke rgieseke merged commit 86dbfd5 into master Jun 26, 2020
@rgieseke rgieseke deleted the 205-docs branch June 26, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc name is wrong
2 participants