Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aerosol ground heat variables #301

Merged
merged 6 commits into from Jul 3, 2020
Merged

Conversation

znicholls
Copy link
Collaborator

@znicholls znicholls commented Jul 2, 2020

Pull request

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable) (N/A)
  • Example added (either to an existing notebook or as a new notebook, where applicable) (N/A)
  • Description in CHANGELOG.rst added

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <http://link-to-pr.com>`_) Added feature which does something
- (`#XX <http://link-to-pr.com>`_) Fixed bug identified in (`#XX <http://link-to-issue.com>`_)

@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #301 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #301   +/-   ##
=======================================
  Coverage   93.38%   93.38%           
=======================================
  Files           7        7           
  Lines        2418     2419    +1     
  Branches      495      495           
=======================================
+ Hits         2258     2259    +1     
  Misses        102      102           
  Partials       58       58           
Impacted Files Coverage Δ
pymagicc/definitions/__init__.py 97.93% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34aceda...69c9732. Read the comment docs.

@znicholls znicholls requested a review from lewisjared July 2, 2020 06:36
@znicholls znicholls marked this pull request as ready for review July 2, 2020 06:37
@znicholls znicholls force-pushed the aerosol-ground-heat-variables branch from bdc3c8f to 69c9732 Compare July 2, 2020 06:38
@lewisjared lewisjared merged commit b422265 into master Jul 3, 2020
@znicholls znicholls deleted the aerosol-ground-heat-variables branch July 3, 2020 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants