Fix naming

[znicholls]

Pull request

Fixes some of the naming to bring us closer to RCMIP conventions

Please confirm that this pull request has done the following:

• Tests added
• Documentation added (where applicable) (N/A)
• Example added (either to an existing notebook or as a new notebook, where applicable) (N/A)
• Description in CHANGELOG.rst added

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <http://link-to-pr.com>`_) Added feature which does something
- (`#XX <http://link-to-pr.com>`_) Fixed bug identified in (`#XX <http://link-to-issue.com>`_)

[znicholls]

@lewisjared sorry about the black changes included here...

I wonder if now is the time to bite the bullet and switch things across to RCMIP names, or do we think that will cause too much chaos in downstream uses?

[znicholls]

I wonder if now is the time to bite the bullet and switch things across to RCMIP names, or do we think that will cause too much chaos in downstream uses?

Actually let's not do it everywhere now, chaos really would ensue. One for pymagicc 3.0, can be tracked with in #312.

[codecov]

Codecov Report

Merging #311 into master will decrease coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #311      +/-   ##
==========================================
- Coverage   93.47%   93.31%   -0.17%     
==========================================
  Files          18       18              
  Lines        2483     2482       -1     
  Branches      483      483              
==========================================
- Hits         2321     2316       -5     
- Misses        103      105       +2     
- Partials       59       61       +2     

Impacted Files	Coverage Δ
pymagicc/io/prn_files.py	90.41% <ø> (ø)
pymagicc/definitions/__init__.py	97.92% <100.00%> (-0.02%)	⬇️
pymagicc/io/__init__.py	88.63% <100.00%> (ø)
pymagicc/core.py	87.80% <0.00%> (-0.83%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b60d280...b010a70. Read the comment docs.

[lewisjared]

LGTM. One decision left:

• 'Surface Temperature' to 'Surface Air Temperature Change'
  I'd keep it out of this PR and deal with that pain later. It isn't 100% RCMIP, but close enough...