Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update naming conventions #317

Merged
merged 7 commits into from Dec 6, 2020
Merged

Update naming conventions #317

merged 7 commits into from Dec 6, 2020

Conversation

znicholls
Copy link
Collaborator

@znicholls znicholls commented Nov 16, 2020

Pull request

Another step on the slow walk towards consistent RCMIP naming (this just hot-fixes a few variables)

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable) (N/A)
  • Example added (either to an existing notebook or as a new notebook, where applicable) (N/A)
  • Description in CHANGELOG.rst added

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <http://link-to-pr.com>`_) Added feature which does something
- (`#XX <http://link-to-pr.com>`_) Fixed bug identified in (`#XX <http://link-to-issue.com>`_)

@znicholls znicholls marked this pull request as ready for review November 16, 2020 08:26
@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #317 (a520731) into master (07a7e9f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #317      +/-   ##
==========================================
+ Coverage   93.29%   93.31%   +0.01%     
==========================================
  Files          18       18              
  Lines        2490     2497       +7     
  Branches      486      488       +2     
==========================================
+ Hits         2323     2330       +7     
  Misses        105      105              
  Partials       62       62              
Impacted Files Coverage Δ
pymagicc/definitions/__init__.py 98.02% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07a7e9f...a520731. Read the comment docs.

@znicholls
Copy link
Collaborator Author

@lewisjared fyi this unifies things a bit more (not quite RCMIP compatible yet but getting there)

@znicholls znicholls merged commit 7aade1e into master Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant