Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for conflict clashes #321

Merged
merged 5 commits into from
Jan 14, 2021
Merged

Check for conflict clashes #321

merged 5 commits into from
Jan 14, 2021

Conversation

znicholls
Copy link
Collaborator

@znicholls znicholls commented Jan 14, 2021

Pull request

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable) (N/A)
  • Example added (either to an existing notebook or as a new notebook, where applicable) (N/A)
  • Description in CHANGELOG.rst added

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <http://link-to-pr.com>`_) Added feature which does something
- (`#XX <http://link-to-pr.com>`_) Fixed bug identified in (`#XX <http://link-to-issue.com>`_)

@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #321 (218f949) into master (35f0040) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
+ Coverage   93.31%   93.34%   +0.02%     
==========================================
  Files          18       18              
  Lines        2497     2508      +11     
  Branches      488      492       +4     
==========================================
+ Hits         2330     2341      +11     
  Misses        105      105              
  Partials       62       62              
Impacted Files Coverage Δ
pymagicc/core.py 88.08% <100.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35f0040...218f949. Read the comment docs.

@znicholls znicholls marked this pull request as ready for review January 14, 2021 01:12
@lewisjared lewisjared merged commit c77443a into master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants