v2.0

[znicholls]

Pull request

My proposed final tweaks before releasing v2.0

Please confirm that this pull request has done the following:

• Tests added
• Documentation added (where applicable)
• Example added (either to an existing notebook or as a new notebook, where applicable) (N/A)
• Description in CHANGELOG.rst added

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <http://link-to-pr.com>`_) Added feature which does something
- (`#XX <http://link-to-pr.com>`_) Fixed bug identified in (`#XX <http://link-to-issue.com>`_)

[codecov]

Codecov Report

Merging #323 (c3a1ab8) into master (c77443a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
+ Coverage   93.34%   93.35%   +0.01%     
==========================================
  Files          18       18              
  Lines        2508     2513       +5     
  Branches      492      493       +1     
==========================================
+ Hits         2341     2346       +5     
  Misses        105      105              
  Partials       62       62              

Impacted Files	Coverage Δ
pymagicc/io/base.py	94.87% <100.00%> (+0.06%)	⬆️
pymagicc/io/prn_files.py	90.41% <100.00%> (ø)
pymagicc/scenarios/__init__.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e923c02...c3a1ab8. Read the comment docs.

[znicholls]

@rgieseke I've pinned cftime temporarily to get the CI passing. I think it will work again once the windows wheel for cftime 1.3.1 is released, it just hasn't happened yet.

[rgieseke]

Examples in the Readme need to be converted ...

[znicholls]

Examples in the Readme need to be converted

Do we want to keep them? If so, we should probably work out how to test them (#258...)

[rgieseke]

I'm fine with removing them (or some of them).

Tools could be

https://byexamples.github.io/byexample/

https://github.com/nschloe/exdown

[znicholls]

https://github.com/nschloe/exdown

beautiful! Will have a play today

[znicholls]

it just hasn't happened yet

Issue here, not sure how quickly it will happen... Unidata/cftime#224

[znicholls]

Issue here, not sure how quickly it will happen... Unidata/cftime#224

It appears to be a Python 3.6 issue, do we drop support?

[rgieseke]

Issue here, not sure how quickly it will happen... Unidata/cftime#224

It appears to be a Python 3.6 issue, do we drop support?

"Following the release of 3.6.8, we plan to provide security fixes for Python 3.6 as needed through 2021, five years following its initial release."
https://www.python.org/downloads/release/python-360/

Not sure how widespread 3.6 is on Linux distros as default or macOS (or in the OpenSCM community ...).
Droppping the tests on Windows for 3.6 is probably fine.

[lewisjared]

We can pin cftime to 1.3.0 for the time being. I wouldn't drop support Python 3.6 yet as we don't explicitly need any 3.7+ features, but happy to drop Windows Python3.6 tests

[rgieseke]

Not sure how these Windows wheels are produced, but it looks like the split is from 1.3.0 to 1.3.1

https://www.lfd.uci.edu/~gohlke/pythonlibs/#cftime

Maybe easiest to just drop the test on Windows ...

[znicholls]

Maybe easiest to just drop the test on Windows

Fixed it I think

[lewisjared]

Brilliant! Good pickup on the rcps