Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat using online tool #334

Merged
merged 3 commits into from
Aug 4, 2021
Merged

Reformat using online tool #334

merged 3 commits into from
Aug 4, 2021

Conversation

rgieseke
Copy link
Member

@rgieseke rgieseke commented Aug 3, 2021

Adds leading '---' as well.

Adds leading '---'.
@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #334 (8ccdd3b) into master (c9bdd61) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #334      +/-   ##
==========================================
+ Coverage   93.20%   93.25%   +0.04%     
==========================================
  Files          20       20              
  Lines        2591     2594       +3     
  Branches      513      515       +2     
==========================================
+ Hits         2415     2419       +4     
  Misses        111      111              
+ Partials       65       64       -1     
Impacted Files Coverage Δ
pymagicc/io/compact.py 87.50% <100.00%> (+0.32%) ⬆️
pymagicc/io/scen.py 97.66% <100.00%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34fc4c3...8ccdd3b. Read the comment docs.

Copy link
Collaborator

@znicholls znicholls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@rgieseke
Copy link
Member Author

rgieseke commented Aug 3, 2021

Unfortunately still showing this:

image

@znicholls
Copy link
Collaborator

hmm confusing

@rgieseke
Copy link
Member Author

rgieseke commented Aug 3, 2021

I'll either have to install their ruby tool i guess or start afresh from their online cff builder (https://citation-file-format.github.io/cff-initializer-javascript/)

Maybe it can't handle the multiline string.

@znicholls
Copy link
Collaborator

I'll either have to install their ruby tool i guess or start afresh from their online cff builder (https://citation-file-format.github.io/cff-initializer-javascript/)

Ye seems fiddly. I'd start from their tool and then just even use the github preview with the branch (not as elegant as installing their ruby tool of course)

Using https://github.com/citation-file-format/cff-converter-python
```
cffconvert --validate -if CITATION.cff
```
@rgieseke
Copy link
Member Author

rgieseke commented Aug 4, 2021

So the Python tool stopped complaining after adding version, license, and date-released (which would require updating during cutting a release). The warning on GitHub persists but i'm not sure if it's actually parsing the content of a branch.

@znicholls
Copy link
Collaborator

Alright let's just go for it then and see what happens

@rgieseke rgieseke merged commit 9595ead into master Aug 4, 2021
@rgieseke rgieseke deleted the fix-citation-cff branch August 4, 2021 11:45
@rgieseke
Copy link
Member Author

rgieseke commented Aug 4, 2021

If it doesn't work, i'd say we delete the file and let that feature mature a bit ...

@rgieseke
Copy link
Member Author

rgieseke commented Aug 4, 2021

Hmmm ...

image

@rgieseke
Copy link
Member Author

rgieseke commented Aug 4, 2021

Seems, it doesn't support a custom message yet. That's not super-helpful, given the complex citation requirements of MAGICC/Pymagicc.

I'd go for removing it.

rgieseke added a commit that referenced this pull request Aug 4, 2021
Custom message appears not yet to be supported (#334).
@rgieseke rgieseke mentioned this pull request Aug 4, 2021
rgieseke added a commit that referenced this pull request Aug 4, 2021
Custom message appears not yet to be supported (#334).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants