-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reformat using online tool #334
Conversation
Adds leading '---'.
Codecov Report
@@ Coverage Diff @@
## master #334 +/- ##
==========================================
+ Coverage 93.20% 93.25% +0.04%
==========================================
Files 20 20
Lines 2591 2594 +3
Branches 513 515 +2
==========================================
+ Hits 2415 2419 +4
Misses 111 111
+ Partials 65 64 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
hmm confusing |
I'll either have to install their ruby tool i guess or start afresh from their online cff builder (https://citation-file-format.github.io/cff-initializer-javascript/) Maybe it can't handle the multiline string. |
Ye seems fiddly. I'd start from their tool and then just even use the github preview with the branch (not as elegant as installing their ruby tool of course) |
Using https://github.com/citation-file-format/cff-converter-python ``` cffconvert --validate -if CITATION.cff ```
So the Python tool stopped complaining after adding version, license, and date-released (which would require updating during cutting a release). The warning on GitHub persists but i'm not sure if it's actually parsing the content of a branch. |
Alright let's just go for it then and see what happens |
If it doesn't work, i'd say we delete the file and let that feature mature a bit ... |
Seems, it doesn't support a custom I'd go for removing it. |
Custom message appears not yet to be supported (#334).
Custom message appears not yet to be supported (#334).
Adds leading '---' as well.