Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 2 point interpolation/extrapolation #222

Merged
merged 3 commits into from Apr 3, 2023

Conversation

lewisjared
Copy link
Collaborator

@lewisjared lewisjared commented Apr 1, 2023

Pull request

Allow for linear interpolation from only two values and constant extrapolation from a single value

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Example added (either to an existing notebook or as a new notebook, where applicable)
  • Description in CHANGELOG.rst added
  • Merge feat: Add uniform year interpolation #221

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@lewisjared lewisjared changed the title Enable 1 and 2 point interpolation/extrapolation Enable 2 point interpolation/extrapolation Apr 1, 2023
@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (5e94e98) 95.82% compared to head (4dc36f8) 95.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
+ Coverage   95.82%   95.84%   +0.01%     
==========================================
  Files          23       23              
  Lines        2084     2092       +8     
  Branches      370      372       +2     
==========================================
+ Hits         1997     2005       +8     
  Misses         69       69              
  Partials       18       18              
Impacted Files Coverage Δ
src/scmdata/run.py 95.98% <100.00%> (+0.04%) ⬆️
src/scmdata/time.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lewisjared lewisjared self-assigned this Apr 1, 2023
Copy link
Collaborator

@znicholls znicholls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep nice, good to go (pending test tweak) after #221

tests/unit/test_timeseries_convertor.py Outdated Show resolved Hide resolved
Linear interpolation using 2 points can be performed instead of 3
values that is currently required.
@lewisjared lewisjared force-pushed the enable-2-point-interpolation branch from ac6fbeb to 4dc36f8 Compare April 3, 2023 03:13
@lewisjared lewisjared merged commit 0e63108 into master Apr 3, 2023
25 checks passed
@lewisjared lewisjared deleted the enable-2-point-interpolation branch April 3, 2023 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants