Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to change the wind #1847

Closed
CanisLupus518 opened this issue Nov 2, 2021 · 3 comments · Fixed by #1849
Closed

Allow user to change the wind #1847

CanisLupus518 opened this issue Nov 2, 2021 · 3 comments · Fixed by #1849
Labels
feature Addition of a COMPLETELY NEW feature has pull request Add this label when an issue has a PR which will resolve it

Comments

@CanisLupus518
Copy link
Contributor

Enhancement to allow the user to change the wind direction and speed.

CanisLupus518 added a commit that referenced this issue Nov 2, 2021
…nge the wind speed and direction used in the sim
CanisLupus518 added a commit that referenced this issue Nov 2, 2021
@CanisLupus518 CanisLupus518 added enhancement Notable improvement or expansion upon an EXISTING feature has pull request Add this label when an issue has a PR which will resolve it labels Nov 2, 2021
CanisLupus518 added a commit that referenced this issue Nov 3, 2021
@JonasCir
Copy link
Member

JonasCir commented Nov 3, 2021

Hey @CanisLupus518 really cool enhancement! 🚀
I have only one thing which might confuse people: I would not look for this setting under the "traffic" menu tab.
Is there a chance to rename the menu entry and also change the "Traffic rate" heading of the menu which opens?

"Simulation parameters" might be to lengthy though... Maybe someone has a better idea? :D


On second read, "Simulation" as menu entry and "Simulation parameters" as heading for the opening menu might be ok?

@CanisLupus518
Copy link
Contributor Author

@JonasCir my intention is that this is the first entry in a series of PRs that are intended to build out functionality for changing the Airport Configuration. This feature and #1848 are the first 2 components of that. Once these changes get merged in, my next step is to introduce a new button in the settings group, could be "Simulation", but I was thinking "Configuration". I think this is where the wind settings, the video map selection, and.. eventually, the selection of active runways should live. SO yes, I would say in essence you're idea is the plan, but I was trying to break up the feature into smaller PRs while also getting my feet wet with the openscope codebase.

@erikquinn erikquinn added feature Addition of a COMPLETELY NEW feature and removed enhancement Notable improvement or expansion upon an EXISTING feature labels Nov 4, 2021
@erikquinn erikquinn changed the title Dynamic Wind Allow user to change the wind Nov 4, 2021
@JonasCir
Copy link
Member

JonasCir commented Nov 5, 2021

Sounds great @CanisLupus518 ! Thank you for your work!

@erikquinn erikquinn mentioned this issue Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Addition of a COMPLETELY NEW feature has pull request Add this label when an issue has a PR which will resolve it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants