Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom bar shows "loading" after airport change #885

Closed
erikquinn opened this issue Feb 15, 2018 · 3 comments
Closed

Bottom bar shows "loading" after airport change #885

erikquinn opened this issue Feb 15, 2018 · 3 comments
Assignees
Labels
refactor Code changes that neither fix a defect nor add functionality
Milestone

Comments

@erikquinn
Copy link
Member

erikquinn commented Feb 15, 2018

Browser: Chrome
Airport: All

Issue Description

"Loading..." is displayed in the bottom right of the scope (over top of the bottom bar) when all loading should be complete.

Steps to reproduce

  1. Clear cache and load openscope fresh
  2. Change to any other airport via the airport selection dialog
  3. Observe the "loading..." shown at the bottom right (and the lack of terrain*)
  4. Refresh page, and observe the same airport comes back up, but without the "loading..."

*the terrain issue can be rectified by dragging or twice clicking the terrain toggle

image

@erikquinn erikquinn added the BUGFIX Defect of the simulator, airport, or aircraft label Feb 15, 2018
@erikquinn erikquinn added this to the v6.0.0 milestone Feb 15, 2018
@n8rzz
Copy link
Member

n8rzz commented Feb 15, 2018

Oh gross. I thought I’d completely removed that ages ago.

@eliuuk
Copy link
Member

eliuuk commented Feb 15, 2018 via email

@erikquinn
Copy link
Member Author

For a while I wasn't sure either. But they all have it, and it goes away on reload, so it's got to be something with the logic used to figure out whether its "loading" or "done loading"...

@n8rzz n8rzz self-assigned this Feb 19, 2018
@n8rzz n8rzz added the has pull request Add this label when an issue has a PR which will resolve it label Feb 19, 2018
@n8rzz n8rzz mentioned this issue Feb 19, 2018
@n8rzz n8rzz added refactor Code changes that neither fix a defect nor add functionality and removed BUGFIX Defect of the simulator, airport, or aircraft labels Feb 19, 2018
@n8rzz n8rzz removed the has pull request Add this label when an issue has a PR which will resolve it label Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code changes that neither fix a defect nor add functionality
Projects
None yet
Development

No branches or pull requests

3 participants