Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove .gitkeep #982

Closed
sam-irl opened this issue May 30, 2018 · 3 comments
Closed

Remove .gitkeep #982

sam-irl opened this issue May 30, 2018 · 3 comments
Assignees
@sam-irl
Labels
refactor Code changes that neither fix a defect nor add functionality
Milestone
v6.2.0

Comments

@sam-irl
Copy link
Member

sam-irl commented May 30, 2018 •
edited by erikquinn

.gitkeep was a dummy file (according to its commit message) and contains no data. It should be removed.
@sam-irl sam-irl added the refactor Code changes that neither fix a defect nor add functionality label May 30, 2018
@sam-irl sam-irl self-assigned this May 30, 2018
@n8rzz
Copy link
Member

n8rzz commented May 30, 2018

.gitkeep Is typically used to maintain folder structures in version control when actual files don’t yet exist.

Where are the files you are referencing here?

@sam-irl
Copy link
Member Author

sam-irl commented May 30, 2018

https://github.com/openscope/openscope/blob/develop/.gitkeep

@n8rzz
Copy link
Member

n8rzz commented May 30, 2018

Holy crap! Yes, let’s get rid of that.

sam-irl pushed a commit that referenced this issue Jun 1, 2018
refactor/982 - add #982 to changelog
bf5cc10
@sam-irl sam-irl mentioned this issue Jun 1, 2018
Merged
@sam-irl sam-irl added the has pull request Add this label when an issue has a PR which will resolve it label Jun 1, 2018
@erikquinn erikquinn added this to the v6.2.0 milestone Jun 2, 2018
@erikquinn erikquinn mentioned this issue Jun 2, 2018
Merged
@n8rzz n8rzz removed the has pull request Add this label when an issue has a PR which will resolve it label Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sam-irl sam-irl

Labels
refactor Code changes that neither fix a defect nor add functionality
Projects
None yet
Milestone
v6.2.0
Development

No branches or pull requests
3 participants
@n8rzz @erikquinn @sam-irl