Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor/1072 - Overhaul of KELP #1073

Merged
merged 1 commit into from
May 14, 2019
Merged

refactor/1072 - Overhaul of KELP #1073

merged 1 commit into from
May 14, 2019

Conversation

JPmAn24
Copy link
Contributor

@JPmAn24 JPmAn24 commented Sep 2, 2018

Resolves #1072

The purpose of this pull request is to Update and Re-introduce KELP into the game.

@erikquinn erikquinn temporarily deployed to openscope-dev-pr-1073 September 2, 2018 23:17 Inactive
@Marcel510 Marcel510 added airport/airline/aircraft Changes to airport/airline/aircraft files refactor Code changes that neither fix a defect nor add functionality WIP Add this label to work-in-progress PRs which are not yet ready for review labels Sep 3, 2018
@Marcel510 Marcel510 changed the title enhancement/1072 refactor/1072 Sep 3, 2018
@erikquinn erikquinn temporarily deployed to openscope-dev-pr-1073 September 6, 2018 20:46 Inactive
@erikquinn erikquinn changed the title refactor/1072 refactor/1072 - Overhaul of KELP Oct 2, 2018
@erikquinn erikquinn temporarily deployed to openscope-dev-pr-1073 October 14, 2018 03:11 Inactive
@erikquinn erikquinn temporarily deployed to openscope-dev-pr-1073 October 14, 2018 03:40 Inactive
@JPmAn24 JPmAn24 requested a review from a team May 5, 2019 03:04
@erikquinn
Copy link
Member

@JPmAn24 I see the WIP label-- is this still a work in progress, or is it ready for review?

@JPmAn24 JPmAn24 removed the WIP Add this label to work-in-progress PRs which are not yet ready for review label May 6, 2019
@JPmAn24
Copy link
Contributor Author

JPmAn24 commented May 6, 2019

@erikquinn Sorry, fixed. It's ready for review now.

@erikquinn erikquinn temporarily deployed to openscope-dev-pr-1073 May 7, 2019 18:33 Inactive
Fechulo
Fechulo requested changes May 7, 2019
View reviewed changes
Copy link
Member

@Fechulo Fechulo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the range ring format, everything looks good to me! Sorry it took so long for me to get around to it

assets/airports/kelp.json Outdated
"center": [31.807327503657113, -106.37640380404419],
"radius_nm": 5.0
},
"rr_radius_nm": 5.0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use the new range ring format here

@Fechulo
Copy link
Member

Fechulo commented May 7, 2019

Also please add the AIRAC tag at the top 😄

@erikquinn erikquinn temporarily deployed to openscope-dev-pr-1073 May 7, 2019 20:02 Inactive
@JPmAn24
Copy link
Contributor Author

JPmAn24 commented May 7, 2019

@Fechulo Done!

@JPmAn24 JPmAn24 requested a review from Fechulo May 7, 2019 20:06
Fechulo
Fechulo approved these changes May 7, 2019
View reviewed changes
Copy link
Member

@Fechulo Fechulo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@erikquinn erikquinn added this to In progress in Medium Priority via automation May 11, 2019
@erikquinn erikquinn added this to In progress in Lower Priority via automation May 11, 2019
@erikquinn erikquinn removed this from In progress in Medium Priority May 11, 2019
@erikquinn erikquinn added this to the v6.13.0 milestone May 11, 2019
@erikquinn erikquinn temporarily deployed to openscope-dev-pr-1073 May 11, 2019 19:25 Inactive
@JPmAn24 JPmAn24 mentioned this pull request May 11, 2019
Merged
@erikquinn
Copy link
Member

Had some merge problems with this last night. Weird stuff in b04ba9f causing the issue. May need to squash to a single commit to get it in. I'll try again hopefully later tonight after work.

@erikquinn erikquinn merged commit c2d30d1 into develop May 14, 2019
Lower Priority automation moved this from In progress to Done May 14, 2019
@erikquinn erikquinn deleted the enhancement/1072 branch May 14, 2019 00:08
@erikquinn
Copy link
Member

Squashed and merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fechulo Fechulo Fechulo approved these changes

Assignees

@JPmAn24 JPmAn24

Labels
airport/airline/aircraft Changes to airport/airline/aircraft files refactor Code changes that neither fix a defect nor add functionality
Projects
Lower Priority
  
Done
Milestone
v6.13.0
Development

Successfully merging this pull request may close these issues.

Re-Introduce El Paso International Airport (KELP)
4 participants
@JPmAn24 @erikquinn @Fechulo @Marcel510