Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement/1387 - Update EDDF to AIRAC 1906 #1388

Merged
merged 6 commits into from
Aug 10, 2019
Merged

Conversation

Marcel510
Copy link
Member

@Marcel510 Marcel510 commented May 23, 2019

Resolves #1362 (AIRAC 1904 changes)
Resolves #1387 (AIRAC 1906 changes)

The purpose of this pull request is to update EDDF to AIRAC 1906

@Marcel510 Marcel510 requested a review from a team May 23, 2019 15:31
@Marcel510 Marcel510 self-assigned this May 23, 2019
@Marcel510 Marcel510 added airport/airline/aircraft Changes to airport/airline/aircraft files enhancement Notable improvement or expansion upon an EXISTING feature labels May 23, 2019
Copy link
Member

@Fechulo Fechulo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's AIRAC 1908 now and there haven't been many changes since 1906, so here's my review based on 1908:

  • Line 2: AIRAC is now 1908 🎉
  • New SIDs:
    • SOBRA1X
    • SOBRA1Y
  • Update airport guide to reflect changes
  • Update changelog entry

This airport has a ridiculous number of procedures (I think I counted 116, there's no way controllers remember them all)

@Marcel510
Copy link
Member Author

@Fechulo
All Done.
I've also updated the spawnPatterns slightly, added a couple of fleets to prevent things like Air Namibia A319 at EDDF. Also BMI Regional ceased operations.

Though I think the EDDF spawnPatterns need a complete remake at some point. There are a lot of airlines that only have a departure spawnPattern but no arrival spawnPattern or vice versa and other things. But that's stuff for a different PR.

@Marcel510 Marcel510 requested a review from Fechulo August 9, 2019 01:53
Copy link
Member

@Fechulo Fechulo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😄 Good work! 🎉

@erikquinn erikquinn merged commit 3ffd13c into develop Aug 10, 2019
@erikquinn erikquinn deleted the enhancement/1387 branch August 10, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airport/airline/aircraft Changes to airport/airline/aircraft files enhancement Notable improvement or expansion upon an EXISTING feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update EDDF to AIRAC 1906 Update EDDF to AIRAC 1904
3 participants