Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/1395 - Fix aircraft's wind correction angle math #1413

Merged
merged 8 commits into from
Aug 16, 2019
Merged

bugfix/1395 - Fix aircraft's wind correction angle math #1413

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
29bfd46
bugfix/1395 - Add _targetHeading and _targetGroundTrack
erikquinn Jul 20, 2019
c3c648a
bugfix/1395 - Fix wind crabbing math
erikquinn Aug 12, 2019
15c8d37
bugfix/1395 - Rename .getWind() methods to be more clear
erikquinn Aug 12, 2019
3a3a8a0
bugfix/1395 - Ensure assigned headings do NOT crab into the wind
erikquinn Aug 12, 2019
e98f462
bugfix/1395 - Add docblock for #targetHeading and #targetGroundTrack
erikquinn Aug 14, 2019
914d289
bugfix/1395 - Update missing references to get tests to pass
erikquinn Aug 14, 2019
4a16a57
bugfix/1395 - Add tests and changelog entry
erikquinn Aug 15, 2019
d7fe63f
bugfix/1395 - Move DA/TAS/winds-aloft increase factor constants to co…
erikquinn Aug 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Bugfixes
- [#1418](https://github.com/openscope/openscope/issues/1418) - Fix error from EDDF spawn pattern
- [#1395](https://github.com/openscope/openscope/issues/1395) - Fix aircraft's wind correction angle math (which was causing go-arounds)


### Enhancements & Refactors
Expand Down
4 changes: 2 additions & 2 deletions src/assets/scripts/client/aircraft/AircraftCommander.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ export default class AircraftCommander {
* @param aircraft {AircraftModel}
*/
runFlyPresentHeading(aircraft) {
return aircraft.pilot.maintainPresentHeading(aircraft.heading);
return aircraft.pilot.maintainPresentHeading(aircraft);
}

/**
Expand Down Expand Up @@ -635,7 +635,7 @@ export default class AircraftCommander {
const spotInQueue = runway.getAircraftQueuePosition(aircraft.id);
const isInQueue = spotInQueue > -1;
const aircraftAhead = this._aircraftController.findAircraftById(runway.queue[spotInQueue - 1]);
const wind = airport.getWind();
const wind = airport.getWindAtAltitude();
const roundedWindAngleInDegrees = round(radiansToDegrees(wind.angle) / 10) * 10;
const roundedWindSpeed = round(wind.speed);
const readback = {};
Expand Down
Loading