Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devops/1410 (B) - Restore functionality of local server from npm run start #1415

Merged
merged 1 commit into from
Aug 10, 2019

Conversation

erikquinn
Copy link
Member

Resolves #1410.
Related: #1411.

Thanks to @wrksx for the solution!

Confirmed this does fix the issue for me (on the laptop-- unable to check on the other machine).

@erikquinn erikquinn added the devops About developer tools label Aug 7, 2019
@erikquinn erikquinn added this to the v6.14.0 milestone Aug 7, 2019
@erikquinn erikquinn requested a review from n8rzz August 7, 2019 20:41
@erikquinn erikquinn self-assigned this Aug 7, 2019
@erikquinn erikquinn added this to In progress in Top Priority via automation Aug 7, 2019
@erikquinn erikquinn mentioned this pull request Aug 7, 2019
Top Priority automation moved this from In progress to Reviewer approved Aug 8, 2019
Copy link
Member

@n8rzz n8rzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll go with this for now, so things can run locally, but still keep #1411 open to actually remove the local server

@erikquinn erikquinn merged commit ba6c470 into develop Aug 10, 2019
Top Priority automation moved this from Reviewer approved to Done Aug 10, 2019
@erikquinn erikquinn deleted the devops/1410-B branch August 10, 2019 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops About developer tools
Projects
Top Priority
  
Done
Development

Successfully merging this pull request may close these issues.

build:scripts:server fails to copy server.js to public/
2 participants