Option to flip back of board 180º #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, flip usually means back to front (and is used this way in code too), not in plane rotation. I think "Offset back rotation" is better. Code looks great. Only thing: the checkbox in html settings looks wedged. Put it in the same box as the rotation slider, right under it. Basically like it looks in the config dialog. |
|
Updated with new display name and variables names everywhere, as well as the HTML layout change. Will you squash on merge, or would you like me to force-push a single commit for all of this? |
dotsam
changed the title
|
Squashed and merged, thanks for contributing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #328
I'm not totally sold on "Flip Back" as the friendly/user-facing name of this feature, so I'm open to suggestions on other things to call it.