Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.1 estat flags #16

Closed
wants to merge 7 commits into from
Closed

Conversation

Tungurahua
Copy link

I tried to use readSDMXon a Eurostat REST call. For this to succeed we need to pass in httpheader information (more specific: list('User-Agent'='R').

I added an argument to readSDMX that solves the problem though I am not sure if this is the right way to do this.

I also added an example that demonstrates the direct download from Eurostat.

@eblondel
Copy link
Member

Using httpheader would be very good...I'm wondering if we might use it by default, instead of a new param...to investigate.

For the tests, before commiting, the best is to run R CMD Check. Once you get a successful check, you can commit, and will be 99% sure that Travis will work well. Before going into codings, i think also that we should start with creating an issue to discuss the new feature / bug etc (by default, since we don't have mailing list), then commit on your fork giving the message: master #issuenb message (this will feed the ticket). Try also not to mix things in pull requests.. just handle one specific ticket implementation. Once everything is working, you can send your pull request... I will add some development guidelines, since this is missing i admit..

For this i would prefer that we close this pull..and go with a clean one, less commits, & no travis nightmare :-). Let's discuss first the need of adding httpheader. I'm creating a ticket for this... We will discuss later #17

@eblondel eblondel closed this Jul 18, 2014
@eblondel
Copy link
Member

@Tungurahua please look to https://github.com/opensdmx/rsdmx/wiki#package_contributions that i have just created. I've also created a ticket #18 that we can start looking to.

@Tungurahua
Copy link
Author

@eblondel thanks for the guidance notes and clarifications on how to use Travis. Focusing on issues first to clarify the why and what of a feature is indeed a more reasonable approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants