OpenSDS installation using Helm charts with Ceph backend #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@leonwanghui PTAL. |
|
Generally it looks good, I’ll have test after the vacation |
|
Hi @Click2Cloud-Gamma, please rebase the target branch to |
leonwanghui
reviewed
Feb 11, 2019
Added tgt-conf-dir part
Now it will take input about the image from values.yml
|
@Click2Cloud-Gamma Please address the errors, thanks! |
leonwanghui
changed the title
leonwanghui
reviewed
Apr 22, 2019
|
Thanks @Click2Cloud-Gamma , I will take a test for this patch. |
leonwanghui
reviewed
Apr 24, 2019
leonwanghui
suggested changes
Apr 24, 2019
There was a problem hiding this comment.
Please update the doc based on https://github.com/opensds/opensds/wiki/OpenSDS-Integration-with-Kubernetes-CSI
leonwanghui
reviewed
Apr 24, 2019
| @@ -21,10 +21,14 @@ spec: | |||
| hostNetwork: true | |||
| containers: | |||
| - name: node-driver-registrar | |||
| image: quay.io/k8scsi/csi-node-driver-registrar:v1.0.1 | |||
|
@Click2Cloud-Gamma I'm afraid you have deleted your folk, and I can't find the project in your code repo, PTAL |
|
Need rebase. |
leonwanghui
suggested changes
May 8, 2019
| @@ -39,7 +39,7 @@ spec: | |||
| serviceAccount: csi-attacher | |||
| containers: | |||
| - name: csi-attacher | |||
| image: quay.io/k8scsi/csi-attacher:v1.0.1 | |||
| image: quay.io/k8scsi/csi-attacher:v0.4.0 | |||
There was a problem hiding this comment.
Please use v1.0.1 because it supports stable v1.0.0 csi spec and is supported by k8s v1.13.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.