Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add host info to xxxReplicationDriverData, add failback function #364

Merged
merged 1 commit into from Apr 25, 2018
Merged

Add host info to xxxReplicationDriverData, add failback function #364

merged 1 commit into from Apr 25, 2018

Conversation

xxwjj
Copy link
Collaborator

@xxwjj xxwjj commented Apr 25, 2018

What this PR does / why we need it:

  1. Add host ip , host name to replication driver data.
  2. Add failback function.
  3. Fixed some dorado bugs.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@coveralls
Copy link

coveralls commented Apr 25, 2018 •
edited

Coverage Status

Coverage decreased (-4.0%) to 38.426% when pulling 5f6008c on xxwjj:replication_host_info into b510a44 on opensds:replication.

xing-yang
xing-yang approved these changes Apr 25, 2018
View reviewed changes
Copy link
Collaborator

@xing-yang xing-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xing-yang xing-yang merged commit c78a42b into sodafoundation:replication Apr 25, 2018
@leonwanghui leonwanghui added the patch there is minor code change label May 11, 2018
@xxwjj xxwjj deleted the replication_host_info branch May 15, 2018 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xing-yang xing-yang xing-yang approved these changes

Assignees

@xxwjj xxwjj

Labels
patch there is minor code change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xxwjj @coveralls @xing-yang @leonwanghui