Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thin OpenSDS Feature #696

Conversation

Click2Cloud-Gamma
Copy link
Contributor

Thin OpenSDS Features

  • Only one storage backend is supported at a given time based on configure setting.
  • Only functionalities supported by CSI spec are supported. These include create/delete volume, attach/detach volume, and create/delete snapshot
    *Communication between API server and dock will be through gRPC
  • For Thin OpenSDS Dock will update the status in database after process completion.
  • install_type parameter in opensds.conf will determine whether to install "Thin openSDS" or the OpenSDS with Controller.
    Reference document: https://docs.google.com/document/d/16zLCE1X8bNjkGoKvBpqDZaxEHZapWluQVgdvlxuR_tE/edit#

@Click2Cloud-Gamma Click2Cloud-Gamma changed the title Thin openSDS Feature Thin OpenSDS Feature Apr 27, 2019
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 30.322% when pulling c6e63fa on Click2Cloud-Gamma:thin_opensds_branch into c33b3cf on opensds:development.

@coveralls
Copy link

coveralls commented Apr 27, 2019

Coverage Status

Coverage decreased (-0.3%) to 28.035% when pulling 9c05071 on Click2Cloud-Gamma:thin_opensds_branch into e62cde3 on opensds:development.

pkg/api/controllers/volume.go Show resolved Hide resolved
examples/opensds.conf Outdated Show resolved Hide resolved
pkg/api/controllers/volume.go Outdated Show resolved Hide resolved
pkg/api/controllers/volume.go Outdated Show resolved Hide resolved
pkg/api/controllers/volume.go Outdated Show resolved Hide resolved
pkg/dock/dock.go Show resolved Hide resolved
pkg/dock/dock.go Outdated Show resolved Hide resolved
pkg/dock/dock.go Show resolved Hide resolved
pkg/dock/dock.go Show resolved Hide resolved
pkg/dock/dock.go Outdated Show resolved Hide resolved
@xing-yang
Copy link
Collaborator

@leonwanghui PTAL.

@leonwanghui leonwanghui added the feature there is a huge framework change or feature addition label May 5, 2019
@leonwanghui leonwanghui added this to In progress in Capri Release Planning via automation May 5, 2019
@leonwanghui
Copy link
Collaborator

Need rebase for this PR.

pkg/api/controllers/volume.go Outdated Show resolved Hide resolved
pkg/api/controllers/volume.go Outdated Show resolved Hide resolved
pkg/api/controllers/volume.go Outdated Show resolved Hide resolved
@Click2Cloud-Gamma
Copy link
Contributor Author

@leonwanghui @wisererik Please review.
Thanks.

pkg/api/controllers/volume.go Outdated Show resolved Hide resolved
pkg/api/controllers/volume.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #696 into development will decrease coverage by 0.27%.
The diff coverage is 0.78%.

@@               Coverage Diff               @@
##           development     #696      +/-   ##
===============================================
- Coverage        31.73%   31.46%   -0.28%     
===============================================
  Files               82       82              
  Lines            15017    15124     +107     
===============================================
- Hits              4766     4759       -7     
- Misses            9554     9668     +114     
  Partials           697      697
Impacted Files Coverage Δ
pkg/api/controllers/volume.go 20.84% <0.78%> (-6.74%) ⬇️

pkg/api/controllers/volume.go Outdated Show resolved Hide resolved
pkg/api/controllers/volume.go Outdated Show resolved Hide resolved
pkg/api/controllers/volume.go Outdated Show resolved Hide resolved
pkg/api/controllers/volume.go Outdated Show resolved Hide resolved
pkg/api/controllers/volume.go Outdated Show resolved Hide resolved
pkg/api/controllers/volume.go Outdated Show resolved Hide resolved
pkg/api/controllers/volume.go Outdated Show resolved Hide resolved
pkg/api/controllers/volume.go Show resolved Hide resolved
pkg/api/controllers/volume.go Outdated Show resolved Hide resolved
pkg/api/controllers/volume.go Show resolved Hide resolved
@leonwanghui
Copy link
Collaborator

I suggest you can test it offline before pushing the code.

@leonwanghui leonwanghui mentioned this pull request Jun 13, 2019
@leonwanghui
Copy link
Collaborator

Referenced by #854

Capri Release Planning automation moved this from In progress to Done Jun 13, 2019
@xing-yang
Copy link
Collaborator

@wisererik Currently Hotpot does not support multiple pools for the same backend. Therefore 1 pool = 1 backend. For Thin OpenSDS, it acts as a CSI plugin for one backend therefore there won't be a way to choose between different backends (or different pools). So using "thin" as an install type should not be a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature there is a huge framework change or feature addition
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants