Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3rd party conf support for telemetry #767

Merged
merged 3 commits into from
May 23, 2019

Conversation

rhsakarpos
Copy link
Contributor

What this PR does / why we need it:

Add 3rd party conf support for telemetry

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
fixes #691

Special notes for your reviewer:

Release note:

@coveralls
Copy link

coveralls commented May 22, 2019

Coverage Status

Coverage increased (+0.0007%) to 28.276% when pulling aa8f580 on rhsakarpos:development-conf into 956e311 on opensds:development.

@rhsakarpos
Copy link
Contributor Author

@leonwanghui @skdwriting @xing-yang @NajmudheenCT please review, thanks.

Copy link
Collaborator

@wisererik wisererik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leonwanghui leonwanghui added the patch there is minor code change label May 22, 2019
pkg/api/controllers/metrics.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@leonwanghui leonwanghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leonwanghui leonwanghui merged commit 5a9e704 into sodafoundation:development May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch there is minor code change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants