Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fileshare controller unit test cases for create/delete fileshare and create/delete filesharesnapshots #792

Merged

Conversation

Shruthi-1MN
Copy link
Contributor

What this PR does / why we need it:
Add fileshare controller unit test cases for create/delete fileshare and create/delete filesharesnapshots

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@coveralls
Copy link

coveralls commented May 29, 2019

Coverage Status

Coverage increased (+0.004%) to 34.82% when pulling e1fa28d on Shruthi-1MN:controller-ut-fileshare into 038d649 on opensds:development.

@leonwanghui leonwanghui added the patch there is minor code change label May 29, 2019
pkg/controller/fileshare/filesharecontroller_test.go Outdated Show resolved Hide resolved
pkg/controller/fileshare/filesharecontroller_test.go Outdated Show resolved Hide resolved
pkg/controller/fileshare/filesharecontroller_test.go Outdated Show resolved Hide resolved
pkg/controller/fileshare/filesharecontroller_test.go Outdated Show resolved Hide resolved
pkg/controller/fileshare/filesharecontroller_test.go Outdated Show resolved Hide resolved
pkg/controller/fileshare/filesharecontroller_test.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@leonwanghui leonwanghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leonwanghui leonwanghui merged commit fc709cb into sodafoundation:development May 29, 2019
@leonwanghui leonwanghui mentioned this pull request May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch there is minor code change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants