Manage preventDefaultAction flag inside canvas-double-click viewer event #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trigger the canvas-double-click event before default double tap to zoom happens on the viewer
|
@ooystein Looks great! This is technically a breaking change, so I think I want to land it after we get 2.3.1 out, but I think it's otherwise ready to go. |
|
If this needs to wait for a new minor/major release, I could probably check if there are more events that should be updated for that release. And maybe add tests for events already using the preventDefaultAction flag |
|
That would be fantastic! |
|
Okay, 2.3.1 is released, so I'm landing this. Thanks again for the patch and the test! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trigger the canvas-double-click event before default double tap to zoom happens on the viewer.
Similar to #1148 but for double click.